Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Runtime CR to create a kubeconfig #1106

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Use Runtime CR to create a kubeconfig #1106

merged 6 commits into from
Sep 11, 2024

Conversation

piotrmiskiewicz
Copy link
Member

@piotrmiskiewicz piotrmiskiewicz commented Sep 10, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • kubeconfig endpoint uses Runtime CR if exists (needed for KIM integration)

Related issue(s)

#791
#905

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 10, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@piotrmiskiewicz piotrmiskiewicz marked this pull request as ready for review September 10, 2024 14:16
@piotrmiskiewicz piotrmiskiewicz requested a review from a team as a code owner September 10, 2024 14:16
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2024
@piotrmiskiewicz piotrmiskiewicz added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Sep 10, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 11, 2024
@kyma-bot kyma-bot merged commit 13bd352 into kyma-project:main Sep 11, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrmiskiewicz @kyma-bot @jaroslaw-pieszka